Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: Use MacOS 12 runners for releases #16479

Merged
merged 1 commit into from
Feb 3, 2024
Merged

internal: Use MacOS 12 runners for releases #16479

merged 1 commit into from
Feb 3, 2024

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Feb 3, 2024 •
edited
Loading

CC #16457

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2024
@lnicola
Copy link
Member Author

lnicola commented Feb 3, 2024 •
edited
Loading

We could probably bump MACOSX_DEPLOYMENT_TARGET too, it's set to 10.15 now, but it's probably 12.7 or something. rust-lang/rust uses 10.12 and 11.0.

@lnicola
Copy link
Member Author

lnicola commented Feb 3, 2024

Test run at https://github.com/lnicola/rust-analyzer/actions/runs/7768338176.

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 3, 2024

📌 Commit a605b96 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 3, 2024

⌛ Testing commit a605b96 with merge 0113bc9...

@lnicola lnicola changed the title internal: Bump release runners to MacOS 12 internal: Use MacOS 12 runners for releases Feb 3, 2024
@bors
Copy link
Collaborator

bors commented Feb 3, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 0113bc9 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Feb 3, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 0113bc9 to master...

@bors bors merged commit 0113bc9 into rust-lang:master Feb 3, 2024
11 checks passed
@lnicola lnicola deleted the macos-12 branch February 3, 2024 17:39
@bors
Copy link
Collaborator

bors commented Feb 3, 2024

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

This was referenced May 9, 2024
Closed
Closed
Closed
Closed
Merged
This was referenced May 28, 2024
Merged
Closed
Closed
Closed
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 4, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 18, 2024
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lnicola @bors @rustbot