Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Move salsa fork in-tree #16503

Merged
merged 7 commits into from
Feb 7, 2024
Merged

internal: Move salsa fork in-tree #16503

merged 7 commits into from
Feb 7, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Feb 6, 2024

No one else is supposed to rely on it anyways, this makes it easier to edit.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 6, 2024
@davidbarsky
Copy link
Contributor

davidbarsky commented Feb 7, 2024

i was going to send a PR with this change, but i'm glad you got here first!

@Veykril
Copy link
Member Author

Veykril commented Feb 7, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 7, 2024

📌 Commit 3688064 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 7, 2024

⌛ Testing commit 3688064 with merge 2d2ddd3...

@bors
Copy link
Collaborator

bors commented Feb 7, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 2d2ddd3 to master...

@bors bors merged commit 2d2ddd3 into rust-lang:master Feb 7, 2024
11 checks passed
@Veykril Veykril deleted the salsa branch February 7, 2024 17:02
@lnicola
Copy link
Member

lnicola commented Feb 7, 2024

I was worried this would slow down the builds, but it doesn't seem noticeable.

@lnicola lnicola changed the title Move salsa fork in-tree internal: Move salsa fork in-tree Feb 7, 2024
@lnicola
Copy link
Member

lnicola commented Feb 7, 2024

@dbarsky does tracing have something like https://docs.rs/test-log/?

image

EDIT: nvm, that's literally test-log 😀.

@davidbarsky
Copy link
Contributor

@dbarsky does tracing have something like https://docs.rs/test-log/?

image

EDIT: nvm, that's literally test-log 😀.

slightly incorrect name, but yes, test-log does this.

@Veykril
Copy link
Member Author

Veykril commented Feb 7, 2024

I was worried this would slow down the builds, but it doesn't seem noticeable.

Why should it?

@lnicola
Copy link
Member

lnicola commented Feb 8, 2024

We exclude the workspace crates from the GitHub cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants