Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Optimize input queries that take no arguments #16505

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Feb 7, 2024

There is no point in having a hashmap and extra lock for this, it is always only a single value. This might speed up some things by a tiny bit for our crate graph query.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 7, 2024
@Veykril
Copy link
Member Author

Veykril commented Feb 7, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 7, 2024

📌 Commit 97cd680 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 7, 2024

⌛ Testing commit 97cd680 with merge 8628352...

@bors
Copy link
Collaborator

bors commented Feb 7, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 8628352 to master...

@bors bors merged commit 8628352 into rust-lang:master Feb 7, 2024
11 checks passed
@Veykril Veykril deleted the unit-salsa branch February 7, 2024 17:21
@lnicola lnicola changed the title Optimize input queries that take no arguments internal: Optimize input queries that take no arguments Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants