Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable some minor lints that we should tackles #16518

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Enable some minor lints that we should tackles #16518

merged 3 commits into from
Feb 9, 2024

Conversation

tetsuharuohzeki
Copy link
Contributor

This enables these lint rules that are commented as we should tackle at some points.

  • non_canonical_clone_impl
  • non_canonical_partial_ord_impl
  • self_named_constructors

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 9, 2024
@Veykril
Copy link
Member

Veykril commented Feb 9, 2024

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Feb 9, 2024

📌 Commit 1e4171b has been approved by Veykril

It is now in the queue for this repository.

@tetsuharuohzeki
Copy link
Contributor Author

@Veykril Thank you for your quickly review!

@bors
Copy link
Collaborator

bors commented Feb 9, 2024

⌛ Testing commit 1e4171b with merge cdc3e83...

@bors
Copy link
Collaborator

bors commented Feb 9, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing cdc3e83 to master...

@bors bors merged commit cdc3e83 into rust-lang:master Feb 9, 2024
11 checks passed
@tetsuharuohzeki tetsuharuohzeki deleted the enable-some-minor-lints branch February 9, 2024 14:05
This was referenced May 9, 2024
Closed
Closed
Closed
Closed
Merged
This was referenced May 28, 2024
Merged
Closed
Closed
Closed
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 4, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 18, 2024
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tetsuharuohzeki @Veykril @bors @rustbot