Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix "needless return" diagnostic for trailing item declarations #16574

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

davidsemakula
Copy link
Contributor

Fixes #16566

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 15, 2024
crates/hir-def/src/hir.rs Outdated Show resolved Hide resolved
@davidsemakula davidsemakula changed the title fix "needless return" diagnostic for trailing item declarations fix: Fix "needless return" diagnostic for trailing item declarations Feb 15, 2024
@Veykril
Copy link
Member

Veykril commented Feb 15, 2024

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Feb 15, 2024

📌 Commit 9ae0f92 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 15, 2024

⌛ Testing commit 9ae0f92 with merge b9b0d29...

@bors
Copy link
Collaborator

bors commented Feb 15, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing b9b0d29 to master...

@bors bors merged commit b9b0d29 into rust-lang:master Feb 15, 2024
11 checks passed
@davidsemakula davidsemakula deleted the needless-return-fix branch February 15, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect replace return <expr>; with <expr> diagnostic
4 participants