internal: Migrate assists to the structured snippet API, part 7/7 #16577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used for allowing newly generated syntax constructs to be renamed without having to go through a separate rename step.
rustbot
added
the
S-waiting-on-review
All assists have been migrated to use the structured snippet versions of these methods.
DropDemBits
force-pushed
the
structured-snippet-migrate-7
branch
from
ae6d4fe
to
4af075d
Compare
|
@nemethf Discovered another snippet rendering issue which causes the placeholders to be placed a little weirdly, but they do still get placed and end up in the final |
|
#16579 fixes the snippet rendering issues I encountered while testing this. |
Veykril
approved these changes
Feb 16, 2024
|
Thanks! |
|
☀️ Test successful - checks-actions |
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #16467
Migrates the following assists:
generate_trait_from_implThis adds
add_placeholder_snippet_group, which adds a group of placeholder snippets which are linked together and allows for renaming generated items without going through a separate rename step.This also removes the last usages of
SourceChangeBuilder::{insert,replace}_snippet, as all assists have finally been migrated to the structured snippet versions of those methods.