Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: Downgrade actions/checkout in release workflow #16598

Merged
merged 1 commit into from
Feb 19, 2024
Merged

internal: Downgrade actions/checkout in release workflow #16598

merged 1 commit into from
Feb 19, 2024

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Feb 19, 2024

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 19, 2024
@lnicola
Copy link
Member Author

lnicola commented Feb 19, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 19, 2024

📌 Commit 5913567 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 19, 2024

⌛ Testing commit 5913567 with merge f71049b...

@lnicola
Copy link
Member Author

lnicola commented Feb 19, 2024

CC @LucasFA better me than you https://github.com/rust-lang/rust-analyzer/actions/runs/7952745134/job/21714107181 :-).

@bors
Copy link
Collaborator

bors commented Feb 19, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing f71049b to master...

@bors bors merged commit f71049b into rust-lang:master Feb 19, 2024
11 checks passed
@lnicola lnicola deleted the fix-release branch February 19, 2024 06:46
@LucasFA
Copy link
Contributor

LucasFA commented Feb 19, 2024

My bad, sorry about that. Didn't realise Node 18+ versions weren't compatible with Ubuntu 18.04 actions/checkout#1442 (comment)

Thanks for the rescue 😅

@lnicola
Copy link
Member Author

lnicola commented Feb 19, 2024

Also #16599.

@lnicola
Copy link
Member Author

lnicola commented Feb 19, 2024

And #16600. You did warn me, though.

@LucasFA
Copy link
Contributor

LucasFA commented Feb 19, 2024

I see it's working again from the latest run: https://github.com/rust-lang/rust-analyzer/actions/runs/7956144210

I wasn't expecting several breakages - again, thanks for the rescue and sorry about generating extra work. I'll take this as a lesson on changing CD immediately before a release day, and on system compatibility, I suppose.

@lnicola
Copy link
Member Author

lnicola commented Feb 19, 2024

No worries, part of the breakage was mine anyway 😀.

This was referenced May 9, 2024
Closed
Closed
Closed
Closed
Merged
This was referenced May 28, 2024
Merged
Closed
Closed
Closed
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 4, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 18, 2024
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lnicola @bors @LucasFA @rustbot