Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document nvim 0.10 inlay_hint #16670

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

rikhuijzer
Copy link
Contributor

It took me a few hours to figure out how to enable inlay type hints on Nvim 0.10 with lspconfig. rustaceanvim has already dropped support for them (mrcjkb/rustaceanvim#46 (comment)) and most other plugins, like rust-tools, are depreciated in favor of rustaceanvim.

This PR documents how to enable the inlay hints on Neovim 0.10 and later. I've tested this and changing the on_attach function is the only step that is required.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 25, 2024
@Veykril
Copy link
Member

Veykril commented Feb 25, 2024

Shouldn't such documentation belong to the rustaceanvim docs?

@rikhuijzer
Copy link
Contributor Author

rikhuijzer commented Feb 25, 2024

Shouldn't such documentation belong to the rustaceanvim docs?

Good question. I don't think so. I myself run with lspconfig-only (so without any rust-tools or rustaceanvim) and when I compare the GitHub stars of rustaceanvim and lspconfig, it looks like many people do the same.

This documentation change is in the lspconfig section of the docs. Inlay hints require only Neovim, coc-rust-analyzer, and lspconfig.

@Veykril
Copy link
Member

Veykril commented Feb 26, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 26, 2024

📌 Commit 4060377 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 26, 2024

⌛ Testing commit 4060377 with merge 4585b46...

@bors
Copy link
Collaborator

bors commented Feb 26, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 4585b46 to master...

@bors bors merged commit 4585b46 into rust-lang:master Feb 26, 2024
11 checks passed
@rikhuijzer rikhuijzer deleted the rh/inlay-hints-nvim branch February 26, 2024 11:39
@rikhuijzer
Copy link
Contributor Author

Thanks, @Veykril

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants