internal: Some method resolution cleanups #16749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
on-demand-validation-err
branch
from
fd93e97
to
516330c
Compare
flodiebold
reviewed
Mar 5, 2024
Veykril
force-pushed
the
on-demand-validation-err
branch
2 times, most recently
from
ad25dae
to
b05a197
Compare
davidbarsky
reviewed
Mar 5, 2024
| @@ -438,6 +438,7 @@ impl<'a> InferenceTable<'a> { | |||
| where | |||
| T: HasInterner<Interner = Interner> + TypeFoldable<Interner>, | |||
| { | |||
| // TODO check this vec here | |||
There was a problem hiding this comment.
what sort of check would happen here?
There was a problem hiding this comment.
Oh that was a note to myself to check if we can cache the allocation for that vec here
|
When I tried this out yesterday, this yield a ~10ms improvement on completions! |
|
Hopefully the saves don't come from fcc246e as that is likely to be invalid |
|
Dropped fcc246e for now as it fails the test I've added after. |
Veykril
force-pushed
the
on-demand-validation-err
branch
from
b05a197
to
c679482
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Mar 11, 2024
fix: Fix method resolution snapshotting receiver_ty too early Accidental change in #16749 presumably caused some type mismatches in webrender
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.