Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep attributes in assist 'generate_delegate_trait' #16766

Merged
merged 2 commits into from Mar 6, 2024

Conversation

roife
Copy link
Contributor

@roife roife commented Mar 6, 2024

fix #15198.

This PR address the issue that impl generated by generate_delegate_trait doesn't keep attributes.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2024
@Veykril
Copy link
Member

Veykril commented Mar 6, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 6, 2024

📌 Commit 5c9ce7b has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 6, 2024

⌛ Testing commit 5c9ce7b with merge 52d8ae7...

@bors
Copy link
Collaborator

bors commented Mar 6, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 52d8ae7 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Mar 6, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 52d8ae7 to master...

@bors bors merged commit 52d8ae7 into rust-lang:master Mar 6, 2024
11 checks passed
@bors
Copy link
Collaborator

bors commented Mar 6, 2024

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delegate trait impl assist: #[cfg] is not considered when enumerating impls
5 participants