internal: Add tracing spans to macro generated database #16772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
davidbarsky
reviewed
Mar 6, 2024
| @@ -235,13 +235,24 @@ pub(crate) fn query_group(args: TokenStream, input: TokenStream) -> TokenStream | |||
|
|
|||
| queries_with_storage.push(fn_name); | |||
|
|
|||
| let tracing = if let QueryStorage::Memoized = query.storage { | |||
| let s = format!("{trait_name}::{fn_name}"); | |||
There was a problem hiding this comment.
it's been a second since I last looked at writing proc macros, but I think that quote::format_ident is preferable to allocating here. if that doesn't work, i'd consider making the trait the target here.
There was a problem hiding this comment.
This intentional is a string, because we want to expand it to a string literal, not an ident, Also this allocation happens at expansion time so it doesn't really matter as it doesn't happen when running the query
Veykril
changed the title
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.