Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Skip match diagnostics for partially unknown types #16779

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix: Skip match diagnostics for partially unknown types #16779

merged 1 commit into from
Mar 7, 2024

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Mar 7, 2024

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 7, 2024
@Nadrieril
Copy link
Member

While you're at it, could you add the same check to validate_block before the call to compute_match_usefulness please?

@lnicola lnicola force-pushed the skip-unknown-types-match-diagnostics branch 2 times, most recently from 34889eb to be75056 Compare March 7, 2024 17:10
@lnicola lnicola force-pushed the skip-unknown-types-match-diagnostics branch from be75056 to cd2347e Compare March 7, 2024 17:11
@lnicola
Copy link
Member Author

lnicola commented Mar 7, 2024

Done, and added a test.

Nadrieril
Nadrieril approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@Nadrieril Nadrieril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Veykril
Copy link
Member

Veykril commented Mar 7, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 7, 2024

📌 Commit cd2347e has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 7, 2024

⌛ Testing commit cd2347e with merge 7f19beb...

@bors
Copy link
Collaborator

bors commented Mar 7, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 7f19beb to master...

@bors bors merged commit 7f19beb into rust-lang:master Mar 7, 2024
11 checks passed
@lnicola lnicola deleted the skip-unknown-types-match-diagnostics branch March 7, 2024 17:39
@bors bors mentioned this pull request Mar 7, 2024
Merged
@lnicola lnicola changed the title minor: Skip match diagnostics for partially unknown types fix: Skip match diagnostics for partially unknown types Mar 8, 2024
This was referenced May 9, 2024
Closed
Closed
Closed
Closed
Merged
This was referenced May 28, 2024
Merged
Closed
Closed
Closed
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 4, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 18, 2024
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nadrieril Nadrieril Nadrieril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lnicola @Nadrieril @Veykril @bors @rustbot