internal: Lower outlive goals, respect them in display impls #16996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
changed the title
Veykril
changed the title
Veykril
commented
Apr 2, 2024
Comment on lines
+1354
to
+1366
| lifetime: match lifetime { | ||
| Some(it) => match it.bound_var(Interner) { | ||
| Some(bound_var) => LifetimeData::BoundVar(BoundVar::new( | ||
| DebruijnIndex::INNERMOST, | ||
| bound_var.index, | ||
| )) | ||
| .intern(Interner), | ||
| None => it, | ||
| }, | ||
| None => static_lifetime(), | ||
| }, | ||
| }) | ||
| .intern(Interner) |
There was a problem hiding this comment.
This is kind of ugly, not sure if there is a better way (while also avoiding allocations, or iterating twice). We lower all bounds in a with_shifted_in(DebruijnIndex::ONE which isn't correct for the lifetime of the trait object,
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.