-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: Improve diagnostics performance #17078
Conversation
502dbac
to
a35875f
Compare
if let Pat::ConstBlock(expr) | Pat::Lit(expr) = *pat { | ||
*has_type_mismatches |= infer.type_mismatch_for_expr(expr).is_some(); | ||
if *has_type_mismatches { | ||
return; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The literal patterns don't have the mismatch associated with them, but contained expression within has. This fixes the bug
call we had in one of the tests, so I replaced that with never!
again.
@bors r+ |
☀️ Test successful - checks-actions |
No description provided.