Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: usage of deprecated version of Node.js #17104

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix: usage of deprecated version of Node.js #17104

merged 1 commit into from
Apr 19, 2024

Conversation

hamirmahal
Copy link
Contributor

fixes #17103.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2024
hamirmahal
hamirmahal commented Apr 18, 2024
View reviewed changes
Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other GitHub Actions using deprecated versions of Node.js. This change just tries to fix the problem in .github/workflows/metrics.yaml.

@Veykril
Copy link
Member

Veykril commented Apr 19, 2024

I think we tried this before but had problems afterwards? Not sure if I recall correctly or not

@lnicola
Copy link
Member

lnicola commented Apr 19, 2024

We had problems on the release workflow, the metrics should be fine. But please revert the formatting change.

@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2024
@hamirmahal hamirmahal closed this Apr 19, 2024
@hamirmahal hamirmahal force-pushed the fix/usage-of-deprecated-version-of-node-in-metrics-yml branch from 1547263 to 50bdeaa Compare April 19, 2024 18:16
@hamirmahal hamirmahal reopened this Apr 19, 2024
hamirmahal
hamirmahal commented Apr 19, 2024
View reviewed changes
Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I removed the formatting change.

@lnicola
Copy link
Member

lnicola commented Apr 19, 2024

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 19, 2024

📌 Commit 3d6bd24 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Apr 19, 2024

⌛ Testing commit 3d6bd24 with merge 8621e79...

@bors
Copy link
Collaborator

bors commented Apr 19, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 8621e79 to master...

@bors bors merged commit 8621e79 into rust-lang:master Apr 19, 2024
21 checks passed
@hamirmahal
Copy link
Contributor Author

You're welcome!

@hamirmahal hamirmahal deleted the fix/usage-of-deprecated-version-of-node-in-metrics-yml branch April 19, 2024 18:53
This was referenced May 9, 2024
Closed
Closed
Closed
Closed
Merged
This was referenced May 28, 2024
Merged
Closed
Closed
Closed
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 4, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 18, 2024
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.github/workflows/metrics.yaml uses deprecated Node.js action
5 participants
@hamirmahal @Veykril @lnicola @bors @rustbot