fix: Only generate snippets for extract_expressions_from_format_string if snippets are supported
#17333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used for inserting syntax nodes into existing token trees
- Add doc comments to some `Parse` methods - Uses `Parse::new` more
rustbot
added
the
S-waiting-on-review
3 tasks
Veykril
approved these changes
Jun 3, 2024
|
Thanks! |
|
☀️ Test successful - checks-actions |
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #17332
Fixes
extract_expressions_from_format_stringso that it doesn't generate snippets if the client doesn't support it.