Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Use .get(…) instead of […] in TypeOrConstParam::source(…) and LifetimeParam::source(…) #17348

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

regexident
Copy link
Contributor

Resolves #17344.

…rConstParam::source(…)`

(… and `LifetimeParam::source(…)`)
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2024
@regexident
Copy link
Contributor Author

(@Veykril I took the liberty of applying the change not only to TypeOrConstParam::source(…), but also to LifetimeParam::source(…).)

@Veykril
Copy link
Member

Veykril commented Jun 5, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 5, 2024

📌 Commit 78f3169 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 5, 2024

⌛ Testing commit 78f3169 with merge 48bbdd6...

@bors
Copy link
Collaborator

bors commented Jun 5, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 48bbdd6 to master...

@bors bors merged commit 48bbdd6 into rust-lang:master Jun 5, 2024
11 checks passed
@regexident regexident deleted the fix-type-or-const-param-source branch June 5, 2024 11:13
@lnicola lnicola changed the title Use .get(…) instead of […] in TypeOrConstParam::source(…) and LifetimeParam::source(…) internal: Use .get(…) instead of […] in TypeOrConstParam::source(…) and LifetimeParam::source(…) Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling .source(db) on TypeOrConstParam crashes for impl Trait params
4 participants