Support auto-import in macro #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwin0cheng
commented
May 2, 2020
| &import, | ||
| edit.text_edit_builder(), | ||
| ); | ||
| edit.target(range); |
There was a problem hiding this comment.
I can't get the AssistContext in this closure, so I pass the ctx to ActionBuilder. Another option is passing the ctx directly as closure arguments, but I don't want to change too much code. I will prefer to refactor it in other PR.
There was a problem hiding this comment.
I'm currently trying to implement #1062 and looks like I will have to change it in order to use the insert_use_statement in ra_ide.
So give it a couple of weeks before doing the refactoring :)
|
bors r+ |
|
🔒 Permission denied Existing reviewers: click here to make SomeoneToIgnore a reviewer |
SomeoneToIgnore
approved these changes
May 3, 2020
|
bors r=SomeoneToIgnore
huh, I thought you have r+ rights? Re-added to bors anyway.
…On Mon, 4 May 2020 at 00:33, Kirill Bulatov ***@***.***> wrote:
***@***.**** approved this pull request.
Well, so much for a try.
But I think it's fine to merge this as is.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4268 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANB3M56E4VYYF63GESGE5TRPXWKTANCNFSM4MXZZDBA>
.
|
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #3854