Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start documenting review process #4703

Merged
merged 1 commit into from Jun 3, 2020
Merged

Start documenting review process #4703

merged 1 commit into from Jun 3, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Jun 2, 2020

No description provided.

@matklad matklad force-pushed the review branch 2 times, most recently from af6e4e3 to c2570d0 Compare June 2, 2020 10:22
kjeremy
kjeremy reviewed Jun 2, 2020
View reviewed changes
docs/dev/README.md Outdated Show resolved Hide resolved
kjeremy
kjeremy reviewed Jun 2, 2020
View reviewed changes
docs/dev/README.md Outdated Show resolved Hide resolved
@kjeremy
Copy link
Contributor

kjeremy commented Jun 2, 2020

As small as it is I think mentioning cargo xtask format would be a good idea since it takes the burden of formatting off of the developer.

@matklad matklad marked this pull request as ready for review June 3, 2020 06:28
@matklad
Copy link
Member Author

matklad commented Jun 3, 2020

As small as it is I think mentioning cargo xtask format would be a good idea since it takes the burden of formatting off of the developer.

We mention formatting checks on CI and pre-commit-hook. I am not sure if xtask format is all that useful today, I just use cargo fmt myself.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 3, 2020

Build succeeded:

@bors bors bot merged commit 1bbbeb8 into rust-lang:master Jun 3, 2020
@matklad matklad deleted the review branch June 3, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjeremy kjeremy kjeremy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matklad @kjeremy