Fix inference of indexing argument (partly) #5211
Conversation
|
cargo fmt fails |
| pub trait Index<Idx> { | ||
| type Output; | ||
| } | ||
| } |
There was a problem hiding this comment.
at some point we need to figure a better way to specify such preludes...
I guess, we can do //- core, and have that auto-magically insert everything, but I wonder if it makes sense to keep stuff more granular?
LGTM!
There was a problem hiding this comment.
I do kind of like having it explicit what types/traits are actually needed by the test. Also, keeping it small helps when debugging tests.
There was a problem hiding this comment.
Yeah, that's true. But we might do something granular, but still with only one trait Index written down
//- include(std::core::Index, std::result::Result)but that won't you see at a glance what's going on...
There was a problem hiding this comment.
That might be nice. Maybe there should just be std/core "snippets" that the tests can include.
We need to add the `T: Index<Arg>` obligation to be resolved later as well, otherwise we can't make inferences about `Arg` later based on the `Index` impls. This still doesn't fix indexing with integer variables though; there's a further problem with Chalk floundering because of the variable, I think.
|
bors r+ |
We need to add the
T: Index<Arg>obligation to be resolved later as well, otherwise we can't make inferences aboutArglater based on theIndeximpls.This still doesn't fix indexing with integer variables though; there's a further problem with Chalk floundering because of the variable, I think.