Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Display name in project.json #6297

Merged
merged 4 commits into from Oct 20, 2020
Merged

Support Display name in project.json #6297

merged 4 commits into from Oct 20, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Oct 20, 2020

bors r+
馃

@matklad
Rename declaration_name -> display_name
af4e755 
Declaration names sounds like a name of declaration -- something you
can use for analysis. It empathically isn't, and is just a label
displayed in various UI. It's important not to confuse the two, least
we accidentally mix semantics with UI (I believe, there's already a
case of this in the FamousDefs at least).
@matklad
Introduce CrateDisplayName
a85c428
@matklad
More type safety around names
3b1a648
@matklad
Support Display name in project.json
f753c3e
@matklad matklad mentioned this pull request Oct 20, 2020
Open
@bors
Copy link
Contributor

bors bot commented Oct 20, 2020

Build succeeded:

@bors bors bot merged commit f925735 into rust-lang:master Oct 20, 2020
@lnicola lnicola added the hacktoberfest-accepted Hacktoberfest accepted PR label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted Hacktoberfest accepted PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matklad @lnicola