Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(hir_ty): do not override DisplayTarget in hir_fmt #6396

Merged
merged 1 commit into from Oct 28, 2020
Merged

refactor(hir_ty): do not override DisplayTarget in hir_fmt #6396

merged 1 commit into from Oct 28, 2020

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Oct 28, 2020

Linked to bug discovery from #6387

The main goal is to not use display() method inside hir_fmt to not override any parameters (like DisplayTarget).
cc @flodiebold

@bnjjj
refactor(hir_ty): do not override DisplayTarget in hir_fmt
7322a69 
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@flodiebold
Copy link
Member

bors r+

@flodiebold
Copy link
Member

Thanks!

@bors
Copy link
Contributor

bors bot commented Oct 28, 2020

Build succeeded:

@bors bors bot merged commit e77ac8d into rust-lang:master Oct 28, 2020
@lnicola lnicola added the hacktoberfest-accepted Hacktoberfest accepted PR label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted Hacktoberfest accepted PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bnjjj @flodiebold @lnicola