Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new assist to change visibility of all struct fields #6600

Closed
wants to merge 1 commit into from

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Nov 21, 2020

Adds visibility for each field inside public struct.
It doesn't affect fields with a visibility already set

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@matklad
Copy link
Member

matklad commented Nov 29, 2020

Not sure it pulls its weight -- there's "change visibility" for a single field already, so you can just repeat that. And there are always multiple cursors to do this change manually...

@bnjjj
Copy link
Contributor Author

bnjjj commented Nov 29, 2020

I just wrote this because it was painful for me and after talking with other rustacean it seems I'm not the only one but yes you know... always hard to know if it could fit also for other people

@matklad
Copy link
Member

matklad commented Dec 9, 2020

We don't have a good procedure to decide if the additional benefit of assist when it is useful overweights the additional costs when it is not useful/maintanence cost. So, I am going to go with my gut feeling here, and the gut feeling says that this assist has a rather broad applicability range (any non-private sturts) while it's useful in only few select circumstances, and doesn't feel like an enabling buliding block for powerful combinations.

So, let's close this. We can always add this back if folks complain that they really want this.

@matklad matklad closed this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants