New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest LSP 3.16 #6779
Latest LSP 3.16 #6779
Conversation
9f0eec7
to
1612f57
Compare
bors r+ |
Finally! I really like stuff in 3.16! |
huh, seems like this broke something?
|
Ok, so it works if I upgrade the version of extensions. But this still feels wrong. Either the protocol is not backwards compatible, or |
I think what you're hitting is the difference between two proposed APIs, the latter of which became final. Originally that was a bool param but got changed to an object right before release. That's why there's no backwards guarantee there in the protocol. |
Huh... Still seems like a good idea to not fail over this in lsp-types. The will definitelly be a bunch of vscode sending us bools, and maybe some other editors as welll. |
(specifically because we now require vscode 15.2, so 15.1 users will be stuck with an older extensions, and will get this bewildering error upon update. Don't ask me how I know that :P ) |
Companion to gluon-lang/lsp-types#192