Added a warning if conflicting rust-lang.rust is enabled.

[extremegf]

Added a warning if conflicting rust-lang.rust plugin is enabled.

Resolves #6463

[lnicola]

bors r+

[bors]

Build succeeded:

• Rust (ubuntu-latest)
• Rust (macos-latest)
• TypeScript (ubuntu-latest)
• Rust (windows-latest)
• TypeScript (windows-latest)

[lnicola]

Thanks!

[extremegf]

My pleasure. I'm a big fan of RA!

[lnicola]

Nb. in #6463 I said:

it might be worth checking that the current extension is matklad.rust-analyzer, though

This is because the plan is/was to integrate the rust-analyzer client code into the official extension. If that happens again, your code should be updated to actually check that both are installed.

And maybe we should also check for kalitaalexey.vscode-rust. That one appears to be gone from the marketplace, but I've seen someone using it in #6718.

Anyway, this is probably fine for now.

[extremegf]

This is because the plan is/was to integrate the rust-analyzer client code into the official extension. If that happens again, your code should be updated to actually check that both are installed.

If rust-analyzer client code is integrated, I assume matklad.rust-analyzer will be dropped from the marketplace and replaced by rust-lang.rust. (Or do I misunderstund this process?)

In that case I could check if we are "matklad.rust-analizer" and if not silence the warning, so it doesn't pop up after integration, and log that this chceck can be removed.

And maybe we should also check for kalitaalexey.vscode-rust. That one appears to be gone from the marketplace, but I've seen someone using it in #6718.

I can check for it as well.

[lnicola]

If rust-analyzer client code is integrated, I assume matklad.rust-analyzer will be dropped from the marketplace and replaced by rust-lang.rust. (Or do I misunderstund this process?)

The code is already there (under a configuration flag, but I don't think it works any more), and this extension still exist, so not necessarily 😄.

The simplest way would be to count whether more than one of rust-lang.rust, matklad.rust-analyzer and kalitaalexey.vscode-rust is installed. This would keep working (doing the right thing) even in rust-lang.rust, at the cost of duplicate warnings.

[extremegf]

Ok, how about this? #7002

It detects any combination of conflicts.