Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try serde_path_to_error for LSP InitializeParams #7019

Merged
merged 1 commit into from Dec 23, 2020
Merged

Try serde_path_to_error for LSP InitializeParams #7019

merged 1 commit into from Dec 23, 2020

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Dec 23, 2020

No description provided.

@matklad
Copy link
Member

matklad commented Dec 23, 2020

what the error looks like? (the easiest way to test that would be writing a test)

@lnicola
Copy link
Member Author

lnicola commented Dec 23, 2020

Something like:

Failed to deserialize InitializeParams: capabilities.workspace.workspaceEdit.changeAnnotationSupport: invalid type: boolean `true`, expected struct ChangeAnnotationWorkspaceEditClientCapabilities; {\"processId\":169421,\"clientInfo\":{\"name\":\"Visual Studio Code\",\"version\":\"1.52.1\"},\"locale\":\"en-gb\",\"rootPath\"

But I'd rather not include this test because it depends on the specific behavior of serde_path_to_error.

@matklad
Copy link
Member

matklad commented Dec 23, 2020

Perfect, I meant exactly this -- looking at a single error message

bors r+

not sure why I didn't do this before though...

@bors
Copy link
Contributor

bors bot commented Dec 23, 2020

Build succeeded:

@bors bors bot merged commit 27ccde9 into rust-lang:master Dec 23, 2020
@lnicola lnicola deleted the path-to-error branch December 23, 2020 12:18
@lnicola lnicola restored the path-to-error branch December 23, 2020 12:18
@lnicola lnicola deleted the path-to-error branch December 23, 2020 12:18
@kjeremy
Copy link
Contributor

kjeremy commented Dec 23, 2020

I didn't know this existed. Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lnicola @matklad @kjeremy