Completion context remove exact match method in favor of fields #8027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f using fields added in rust-lang#8008
|
changelog fixup #8008 |
|
@JoshMcguigan could you try to r+ yourself to see if premissions are setup proprely? |
Yep, I was going to give it a shot, but for some reason there was a weird CI test failure caused by a mark not registering as being hit. I'll ask a follow up question in zulip, but otherwise this should be g2g. bors r+ |
|
Discussion of the flakey fail in CI: https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/test.20marks.20flakey.3F/near/230346699 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor cleanup PR following #8008. It removes the
expected_name_and_typemethod on completion context in favor of using the fields.I thought this method was used in more places, or else it may have just made sense to make this change directly in #8008 🤷