Return multiple modules in parent_module feature
#8028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
reviewed
Mar 15, 2021
| @@ -18,8 +19,7 @@ use crate::NavigationTarget; | |||
| // | VS Code | **Rust Analyzer: Locate parent module** | |||
| // |=== | |||
|
|
|||
| /// This returns `Vec` because a module may be included from several places. We | |||
| /// don't handle this case yet though, so the Vec has length at most one. | |||
| /// This returns `Vec` because a module may be included from several places. | |||
|
changelog internal prepare for returning parents in the "Locate parent module" command. |
matklad
reviewed
Mar 15, 2021
Comment on lines
261
to
+265
| pub fn to_module_def(&self, file: FileId) -> Option<Module> { | ||
| self.imp.to_module_def(file).next() | ||
| } | ||
|
|
||
| pub fn to_module_defs(&self, file: FileId) -> impl Iterator<Item = Module> { |
There was a problem hiding this comment.
In the future, we should get rid of the first function. It's problematic in that it's not obvious, at the call site, that more than one result can be returned. Although, just returening a vec in call cases seems wrong as well. Rather, the caller probably wants to pass in some kind of predicate object, which is used to select the best possible module.
So, something like fn guess_module_def(file: FiledId, node: &SyntaxNode) might make sens.
There was a problem hiding this comment.
Ye was thinking about that as well a bit, getting the predicate/heuristic right seems difficult
|
bors r=matklad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.