Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Binders more like Chalk #8348

Merged
merged 7 commits into from Apr 5, 2021
Merged

Make Binders more like Chalk #8348

merged 7 commits into from Apr 5, 2021

Conversation

flodiebold
Copy link
Member

@flodiebold flodiebold commented Apr 5, 2021 •
edited

Working towards #8313.

  • hide value
  • use VariableKinds
  • adjust subst to be like Chalk's substitute
  • also clean up some other TypeWalk stuff to prepare for it being replaced by Chalk's Fold

@flodiebold
Copy link
Member Author

bors r+

changelog internal

@bors
Copy link
Contributor

bors bot commented Apr 5, 2021

Build succeeded:

@bors bors bot merged commit c91b537 into rust-lang:master Apr 5, 2021
@flodiebold flodiebold deleted the binders branch April 5, 2021 18:38
@lnicola
Copy link
Member

lnicola commented Apr 6, 2021

Slight memory usage bump here:

image

@flodiebold
Copy link
Member Author

We could probably fix that by properly interning variable kinds using @jonas-schievink's infrastructure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flodiebold @lnicola