Use CompletionTextEdit::InsertAndReplace if supported by the client

[Veykril]

Fixes #8404, Fixes #3130

[matklad]

completed will replace the entire identifier which might be unwanted(

i think LSP now allows specifying both “append” and “replace” behavior in a single completion. Some times the user wants one, and sometimes the other. I haven’t looked into this closely yet.

[Veykril]

Looks like it, CompletionClientCapabilities has a insertReplaceSupport capability which seems to be what you mean, will take a look at that.

[Veykril]

Seems to work like a charm.

For context from the lsp docs:

/**
	 * An edit which is applied to a document when selecting this completion.
	 * When an edit is provided the value of `insertText` is ignored.
	 *
	 * *Note:* The range of the edit must be a single line range and it must
	 * contain the position at which completion has been requested.
	 *
	 * Most editors support two different operations when accepting a completion
	 * item. One is to insert a completion text and the other is to replace an
	 * existing text with a completion text. Since this can usually not be
	 * predetermined by a server it can report both ranges. Clients need to
	 * signal support for `InsertReplaceEdit`s via the
	 * `textDocument.completion.insertReplaceSupport` client capability
	 * property.
	 *
	 * *Note 1:* The text edit's range as well as both ranges from an insert
	 * replace edit must be a [single line] and they must contain the position
	 * at which completion has been requested.
	 * *Note 2:* If an `InsertReplaceEdit` is returned the edit's insert range
	 * must be a prefix of the edit's replace range, that means it must be
	 * contained and starting at the same position.
	 *
	 * @since 3.16.0 additional type `InsertReplaceEdit`
	 */
	textEdit?: TextEdit | InsertReplaceEdit;

[lnicola]

Does this also close #3130?

[Veykril]

That would also close that issue yes

[Veykril]

bors r+
changelog feature Support InsertReplaceSupport capability
Not entirely sure if this counts as feature or something else

[bors]

Build succeeded:

• Rust (macos-latest)
• Rust (ubuntu-latest)
• Rust (windows-latest)
• TypeScript (ubuntu-latest)
• TypeScript (windows-latest)