Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make sure nightly regressions don't break users #8621

Merged
merged 1 commit into from Apr 22, 2021

Conversation

matklad
Copy link
Member

@matklad matklad commented Apr 22, 2021

No description provided.

@matklad
Copy link
Member Author

matklad commented Apr 22, 2021

r? @lnicola

Thinking more about it, looks like "just push to the release branch" is an OK patch release workflow for now, we don't necessary need to get fancier here. Makes more sense to concentrate on prevention of the problem.

@lnicola
Copy link
Member

lnicola commented Apr 22, 2021

Writing the changelog after a patch release is really hard. I need to at least add a way to do it before Monday.

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 22, 2021

@bors bors bot merged commit d1c9bd1 into rust-lang:master Apr 22, 2021
@matklad
Copy link
Member Author

matklad commented Apr 22, 2021

@lnicola one possible wayt to do that would be to add --prev-release commit-hash arg to the xtask.

@matklad matklad deleted the nightlyr branch April 22, 2021 08:36
@matklad matklad mentioned this pull request Apr 22, 2021
@lnicola
Copy link
Member

lnicola commented Apr 22, 2021

Yeah, that was my plan (well, an env variable, but..).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants