Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing math.rs from the public API #30

Open
FreezyLemon opened this issue Feb 26, 2024 · 0 comments
Open

Consider removing math.rs from the public API #30

FreezyLemon opened this issue Feb 26, 2024 · 0 comments

Comments

@FreezyLemon
Copy link
Contributor

Most of these functions are not inherently tied to v_frame and are just util functions for rav1e. I'd argue that it makes sense to move them to rav1e instead.

The Fixed trait is also kind of unnecessary: Because of orphan rules, there is no way for downstream crates to implement the trait for the other integer types. This means that these functions could also just be simple (non-trait) functions operating on a usize parameter.

I'd suggest making the math.rs a util module and not exposing it publicly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant