Module hierarchy like in nom?

[sdroege]

Currently all types are directly at the top-level of the crate. It potentially makes sense to move them into various sub-modules similar to how it's done in nom.

As part of that, the compat std::io module could also be moved into a nicer place.

And maybe we could also move the macros out of the way into some kind of legacy module and mark them as deprecated :)

What do you think?

[Keruspe]

Something definitely needs to be done wrt this, yep

[Keruspe]

cookie_factory::{
    deprecated::macros::*, // meh, macros are always exported at the root of the crate no matter where they are defined but still...
    no_std::io::*,
    *
}

This could be a first step

[sdroege]

Yeah, sounds like a good start to me. I was also thinking about creating modules like nom's branch, combinator, character, sequence, etc. but those modules would look mostly empty right now so maybe not worth it.

[Geal]

yup, it's a good idea to have modules, better have them now and add stuff later, because changing module paths later will be a breaking change

[sdroege]

Ok, let's go with the top-level modules of nom then as a starting point, plus what @Keruspe said in the first comment above? I can prepare a PR for that if that sounds fine to everybody.

[sdroege]

This is fixed by a265b1c and follow-up commits now