Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vcf-report tests #215

Merged
merged 2 commits into from
Dec 11, 2021
Merged

fix: vcf-report tests #215

merged 2 commits into from
Dec 11, 2021

Conversation

FelixMoelder
Copy link
Member

This adds tests which have not been pushed in the previous PR.

@FelixMoelder
Copy link
Member Author

@fxwiegand Could you have a look at the failing test?
It appears to me as if tests/expected/report/details/a/ENST00000557334_5_c_35G_A.html is not up to date and I would expect a link to the Changelog.md.
But as the line did not change in the last weeks I do not get how the test could have passed before.

@fxwiegand
Copy link
Contributor

@fxwiegand Could you have a look at the failing test?
It appears to me as if tests/expected/report/details/a/ENST00000557334_5_c_35G_A.html is not up to date and I would expect a link to the Changelog.md.
But as the line did not change in the last weeks I do not get how the test could have passed before.

I'd assume the problem is that the additional import moved all lines down so the test doesn't delete the timestamp and version anymore. You'd need to change this line:

.arg("sed -i '35d;28d' ".to_owned() + result)

@FelixMoelder
Copy link
Member Author

FelixMoelder commented Dec 11, 2021

@fxwiegand Could you have a look at the failing test?
It appears to me as if tests/expected/report/details/a/ENST00000557334_5_c_35G_A.html is not up to date and I would expect a link to the Changelog.md.
But as the line did not change in the last weeks I do not get how the test could have passed before.

I'd assume the problem is that the additional import moved all lines down so the test doesn't delete the timestamp and version anymore. You'd need to change this line:

.arg("sed -i '35d;28d' ".to_owned() + result)

Thanks! Guess I would have spent hours to figure that out on my own.

@FelixMoelder FelixMoelder merged commit b3e45b3 into master Dec 11, 2021
@FelixMoelder FelixMoelder deleted the fix_vcf_report_tests branch December 11, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants