removed manual SVD sorting + tested #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the long delay on this, just letting you know I'll be reviewing this today or tomorrow with an aim to merge. The clippy lints have been fixed and merged so it's mainly just double checking all the tests. I'll ping if there are any questions but from a brief glance over it all looks pretty solid so hopefully I can just merge this without any back-and-forth 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for #51
There are 4 cases where SVDs were calculated and manually ordered. These now use the already ordered versions from
nalgebra. I did not find any cases where an unordered SVD is used.Tests were added to ensure everything worked the same as before.