Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Migration::applied public #248

Open
Protryon opened this issue Sep 27, 2022 · 2 comments
Open

Make Migration::applied public #248

Protryon opened this issue Sep 27, 2022 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Protryon
Copy link

In order to implement AsyncMigrate for a custom SQL target, this function is needed to construct Migration types. This is specifically required by the AsyncQuery::query function.

At the moment, this API is pub(crate), requiring an unsafe transmute to construct any Migration type outside of refinery-core crate.

See example in klickhouse crate: https://github.com/Protryon/klickhouse/blob/master/klickhouse/src/migrate.rs#L58

@jxs
Copy link
Member

jxs commented Sep 29, 2022

Hi, and thanks for your interest!
Wouldn't you prefer to have refinery support Clickhouse directly?

@Protryon
Copy link
Author

@jxs Sure, it was simply more expedient for my immediate needs to implement it outside. It's also a bit hacky IMO. I can open a PR here to add support.

@jxs jxs added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants