Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch in name of config file when created by cli setup vs what cli migrate expects #80

Closed
mcobzarenco opened this issue Apr 14, 2020 · 3 comments

Comments

@mcobzarenco
Copy link
Contributor

First, 馃挴 for the project!

The refinery_cli creates a refinery.toml config file when running refinery setup -- however, refinery migrate expects the file to be called Refinery.toml

As a passing comment, in the cli readme, the examples use refinery_cli, but the executable seems to be called refinery when installing as suggested with cargo install refinery_cli.

@jxs
Copy link
Member

jxs commented Apr 14, 2020

The refinery_cli creates a refinery.toml config file when running refinery setup -- however, refinery migrate expects the file to be called Refinery.toml

yeah, that has been fixed in the master, both are now using refinery.toml: https://github.com/rust-db/refinery/blob/master/refinery_cli/src/cli.rs#L18 and https://github.com/rust-db/refinery/blob/master/refinery_cli/src/cli.rs#L18

As a passing comment, in the cli readme, the examples use refinery_cli, but the executable seems to be called refinery when installing as suggested with cargo install refinery_cli.

yeah you are right, want to submit a PR fixing it?
thanks!

@mcobzarenco
Copy link
Contributor Author

mcobzarenco commented Apr 15, 2020

yeah, that has been fixed in the master, both are now using refinery.toml

馃憤 looking forward to a release, but in the meantime I'll switch to installing from master, thanks!

yeah you are right, want to submit a PR fixing it?

Sure thing! (#85)

@jxs
Copy link
Member

jxs commented Apr 15, 2020

+1 looking forward to a release, but in the meantime I'll switch to installing from master, thanks!

yeah I plan too as soon as nightly is fixed and I have time to address other features
thanks

@jxs jxs closed this as completed Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants