Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVR Applications using the heapless crate fail to compile #312

Closed
mutantbob opened this issue Aug 24, 2022 · 3 comments
Closed

AVR Applications using the heapless crate fail to compile #312

mutantbob opened this issue Aug 24, 2022 · 3 comments
Labels

Comments

@mutantbob
Copy link

If you create an AVR project using cargo generate --git https://github.com/Rahix/avr-hal-template.git and add a dependency on heapless (0.7.16) compilation triggers an error

error: cannot find macro `llvm_asm` in this scope
   --> /home/thoth/.cargo/registry/src/github.com-1ecc6299db9ec823/critical-section-0.2.7/src/lib.rs:127:13
    |
127 |             llvm_asm!(
    |             ^^^^^^^^

This is because heapless depends on atomic-polyfill v0.1.10 which depends on critical-section v0.2.7 which uses the obsolete llvm_asm! macro.

Upgrading heapless to use atomic-polyfill 1.0.0 or later resolves this issue.

@booo
Copy link

booo commented Nov 16, 2022

As far as I can see this was solved in b0e4cb8.

I would appreciate a new release with this change so we can start integrating it in other projects.

@rihardsk
Copy link

Hey, sorry to bother, but is there anything specific preventing a new release being created? It would be great to have this fixed so that downstream projects can benefit.

@newAM
Copy link
Member

newAM commented Oct 31, 2023

This should be fixed on the main branch, feel free to re-open if not.

This isn't in a release yet, but we're working on that, tracking issue #373

@newAM newAM closed this as completed Oct 31, 2023
@newAM newAM added the bug label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants