Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serial-unix crate is unmaintained #86

Closed
samgoldman-bionautlabs opened this issue Aug 22, 2022 · 3 comments · Fixed by #89
Closed

serial-unix crate is unmaintained #86

samgoldman-bionautlabs opened this issue Aug 22, 2022 · 3 comments · Fixed by #89
Labels
help wanted Extra attention is needed

Comments

@samgoldman-bionautlabs
Copy link

We have noticed that this crate uses serial-unix which has not been maintained in 5 years: https://github.com/dcuddeback/serial-rs.

Instead the maintained crate serialport (https://github.com/serialport/serialport-rs) could be used.

@eldruin eldruin added the help wanted Extra attention is needed label Aug 23, 2022
@qrasmont
Copy link
Contributor

Hi,

This means Serial::open should become a wrapper around serialport::TTYPort::open instead of serial_unix::TTYPort::open.

Is it then ok to modify the Serial::open signature to match the arguments expected by serialport::TTYPort::open ? Or should the existing signature be preserved ?

@eldruin
Copy link
Member

eldruin commented Mar 15, 2023

Keeping the signature is not a must. It would be nice to keep if possible, though, just because it is currently very straight-forward by simply providing a path.
We have a breaking release in the pipeline so if you are interested, now it would be a great time to have a go at it.

@qrasmont
Copy link
Contributor

The main difference is that serial-rs would rely on termios to get the baud rate while serialport-rs requires the user to provide it to be able to open the port.

So the signature could be maintained by using termios.

@bors bors bot closed this as completed in 1f97fd4 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants