Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AST::LiteralExpr should differentiate between strings and raw strings #2858

Open
CohenArthur opened this issue Feb 16, 2024 · 1 comment
Open

AST::LiteralExpr should differentiate between strings and raw strings #2858

CohenArthur opened this issue Feb 16, 2024 · 1 comment
Assignees
@AnshVM
Labels
enhancement good-first-pr
Milestone
core 1.49 functio...

Comments

@CohenArthur
Copy link
Member

Currently parsing r#"gccrs"# works, but it returns a LiteralExpr with LiteralType of Literal::STRING, but we have a Literal::BYTE_STRING variant. It would be useful to have a Literal::RAW_STRING variant too, and we do need it for format_args!()
@CohenArthur CohenArthur added this to the `format_args!()` support milestone Feb 16, 2024
@AnshVM
Copy link
Contributor

AnshVM commented Feb 18, 2024

Hey, I would like to work on this issue

@AnshVM AnshVM mentioned this issue Mar 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnshVM AnshVM

Labels
enhancement good-first-pr
Projects
format_args!()
Status: In Progress
Milestone
core 1.49 functionality [AST]
Development

Successfully merging a pull request may close this issue.

[WIP] Add RAW_STRING_LITERAL AnshVM/gccrs
2 participants
@CohenArthur @AnshVM