Refactor backend to use finegrained visitors #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also moves more code out of the headers to their associated impl files to improve compilation times and code navigation.
philberty
added this to In progress
in Const generics and missing features sprint
via automation
Const generics and missing features sprint
automation
moved this from In progress
to Reviewer approved
Aug 17, 2022
|
bors r+ |
|
@dafaust hopefully this doesnt affect your work on match expr. The only change here is moving stuff out of the headers and into the .cc files and cleanup the usage of visitors here. |
|
Build succeeded: |
Const generics and missing features sprint
automation
moved this from Reviewer approved
to Done
Aug 17, 2022
Nope all good painless rebase :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also moves more code out of the headers to their associated impl files
to improve compilation times and code navigation.