Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Added experimental flag & updated gccrs path #1751

Merged
merged 1 commit into from Jan 17, 2023
Merged

README.md: Added experimental flag & updated gccrs path #1751

merged 1 commit into from Jan 17, 2023

Conversation

MahadMuhammad
Copy link
Contributor

(1) There is a need of the flag "-frust-incomplete-and-experimental-compiler-do-not-use" because the rust1 compiler didn't work without this.

(2) The gccrs was not present in the $HOME/gccrs-install/, so updated the path to $HOME/gccrs-install/bin

Signed-off-by: MAHAD mahadtxt@gmail.com

(1) There is a need of the flag "-frust-incomplete-and-experimental-compiler-do-not-use" because the rust1 compiler didn't work without this.

(2) The gccrs was not present in the $HOME/gccrs-install/, so updated the path to $HOME/gccrs-install/bin

Signed-off-by: MAHAD <mahadtxt@gmail.com>
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request! And good catch :)

@CohenArthur
Copy link
Member

I think the README deserves some more love as it's probably a bit out of date. I'll merge this for now, and have a look at how to improve it very soon.

bors r+

@tschwinge
Copy link
Member

I had considered to raise the need to update README.md for -frust-incomplete-and-experimental-compiler-do-not-use in its PR #1540 "Implement -frust-incomplete-and-experimental-compiler-do-not-use flag", but then decided to not do so -- in order to not cut new contributors/users out of that first-hand experience. ;-) (But of course I don't object to updating the file, either.)

@bors
Copy link
Contributor

bors bot commented Jan 17, 2023

@bors bors bot merged commit 7c84b3c into Rust-GCC:master Jan 17, 2023
@CohenArthur
Copy link
Member

I had considered to raise the need to update README.md for -frust-incomplete-and-experimental-compiler-do-not-use in its PR #1540 "Implement -frust-incomplete-and-experimental-compiler-do-not-use flag", but then decided to not do so -- in order to not cut new contributors/users out of that first-hand experience. ;-) (But of course I don't object to updating the file, either.)

Yes, that's what I was thinking yesterday as well :) I don't know how to feel about it. I think it's worth mentioning the flag in more detail in the README which will solve that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants