libgrust: Add missed commits for Changelog creation #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
CohenArthur
commented
Feb 15, 2024
CohenArthur
commented
- libgrust: Add ChangeLog file
- libgrust: Add entry for maintainers
tschwinge
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
That's OK if necessary to unblock #2822, as I understand.
There are, however, further changes that need to be backported from upstream GCC master branch into GCC/Rust master branch, to account for rework during upstreaming. I'll (eventually...) look into that in context of #2802.
(Should've used git cherry-pick -x here.) ;-P
CohenArthur
force-pushed
the
libgrust-changelog-commits
branch
from
2e8b2f0
to
61d6d77
Compare
|
@tschwinge re-cherry-picked them with the -x option :) thanks! didn't know it existed |
CohenArthur
force-pushed
the
libgrust-changelog-commits
branch
from
61d6d77
to
e66df91
Compare
libgrust/ChangeLog: * ChangeLog: New file. (cherry picked from commit a857ec6) Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
ChangeLog: * MAINTAINERS: Add maintainers for libgrust. contrib/ChangeLog: * gcc-changelog/git_commit.py: Add libgrust. (cherry picked from commit e4f0eb7) Co-authored-by: Arthur Cohen <arthur.cohen@embecosm.com> Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
P-E-P
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.