Borrowck tests and build #2889
Borrowck tests and build #2889
Conversation
|
there were merge conflicts in "Link Polonius and run it" commit, so I resolved conflicts and rebased from master and created a pull request in your gccrs repository. |
|
Thanks for the enthusiasm, but that might have been a little premature. There is a series of 3 PRs that are open, and that need to stay on top of each other. Do reading just the last one on master might cause problems when the first two are merged.
I have ignored the conflict for now, because the it will take some time to get to this PR. The correct way to do this is to rebase the first on master and the others on top of it. I wanted to delay that to avoid rebasing it many times as master changes. But I guess I could do it now to solve that problem.
…On Thu, 29 Feb 2024, at 07:02, braw-lee wrote:
there were merge conflicts in "Link Polonius and run it" commit, so I resolved conflicts and rebased from master and created a pull request in your gccrs repository.
I am not sure if it was the right thing to do here, lemme know.
—
Reply to this email directly, view it on GitHub <#2889 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFNB76AFANL7NP3CRQ3R6C3YV3B6LAVCNFSM6AAAAABD6SFU66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZQGQ3DKNBVGU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
oops, sorry for jumping the gun, |
jdupak
force-pushed
the
borrowck-stage3
branch
from
71935ac
to
59fdeef
Compare
|
Rebase of all PRs done, now there is no merge conflict. |
|
Cool, didn't know this.
…On Thu, 7 Mar 2024, at 13:51, P-E-P wrote:
***@***.**** commented on this pull request.
In gcc/rust/checks/errors/borrowck/rust-bir-builder-expr-stmt.cc <#2889 (comment)>:
> @@ -433,9 +454,6 @@ ExprStmtBuilder::visit (HIR::LoopExpr &expr)
{
auto loop = setup_loop (expr);
- push_goto (loop.continue_bb);
-
- ctx.current_bb = loop.continue_bb;
(void) visit_expr (*expr.get_loop_block ());
We should probably replace this cast with a proper std call.
⬇️ Suggested change
- (void) visit_expr (*expr.get_loop_block ());
+ std::ignore = visit_expr (*expr.get_loop_block ());
—
Reply to this email directly, view it on GitHub <#2889 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFNB76CRWI2EB5YGH2E3SQDYXBPGNAVCNFSM6AAAAABD6SFU66VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRSGM2TGMJQGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
jdupak
force-pushed
the
borrowck-stage3
branch
2 times, most recently
from
fab7a49
to
4465ea7
Compare
gcc/rust/ChangeLog: * checks/errors/borrowck/polonius/rust-polonius.h (struct FullPoint): Polonius facts dump. (struct Facts): Polonius facts dump. * checks/errors/borrowck/rust-bir-dump.cc (Dump::go): Polonius facts dump. (Dump::visit): Polonius facts dump. (Dump::visit_place): Polonius facts dump. (Dump::visit_move_place): Polonius facts dump. (Dump::visit_scope): Polonius facts dump. * checks/errors/borrowck/rust-borrow-checker.cc (BorrowChecker::go): Polonius facts dump. Signed-off-by: Jakub Dupak <dev@jakubdupak.com>
This is minimalistic version to build Polonius with Cargo. gcc/rust/ChangeLog: * Make-lang.in: Build Polonius. Signed-off-by: Jakub Dupak <dev@jakubdupak.com>
gcc/rust/ChangeLog: * Make-lang.in: Link Polonius. * checks/errors/borrowck/rust-borrow-checker.cc: Run Polonius. Signed-off-by: Jakub Dupak <dev@jakubdupak.com>
gcc/rust/ChangeLog: * checks/errors/borrowck/ffi-polonius/src/gccrs_ffi_generated.rs: Error reporting. * checks/errors/borrowck/ffi-polonius/src/lib.rs: Error reporting. * checks/errors/borrowck/polonius/rust-polonius-ffi.h (struct FactsView): Error reporting. (struct Output): Error reporting. * checks/errors/borrowck/polonius/rust-polonius.h (struct Facts): Error reporting. * checks/errors/borrowck/rust-borrow-checker.cc: Error reporting. Signed-off-by: Jakub Dupak <dev@jakubdupak.com>
gcc/testsuite/ChangeLog: * rust/borrowck/borrowck.exp: New test. * rust/borrowck/position_dependant_outlives.rs: New test. * rust/borrowck/reference.rs: New test. * rust/borrowck/return_ref_to_local.rs: New test. * rust/borrowck/subset.rs: New test. * rust/borrowck/test_move.rs: New test. * rust/borrowck/test_move_behind_reference.rs: New test. * rust/borrowck/test_move_conditional.rs: New test. * rust/borrowck/tmp.rs: New test. * rust/borrowck/use_while_mut.rs: New test. * rust/borrowck/use_while_mut_fr.rs: New test. * rust/borrowck/well_formed_function_inputs.rs: New test.
gcc/rust/ChangeLog: * checks/errors/borrowck/rust-bir-builder-expr-stmt.cc (ExprStmtBuilder::visit): Use std::ignore.
|
@CohenArthur rebased, fixed std::ignore, also the commit with new tests got previously lost before, please check that one extra. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
All commits tested even with gcc48.
Depends on #2885
Related to #2716
@CohenArthur
@braw-lee