Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant macro definition #2925

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Remove redundant macro definition #2925

merged 1 commit into from
Apr 23, 2024

Conversation

zhanghe9702
Copy link
Contributor

gcc/rust/ChangeLog:
* backend/rust-tree.h: remove redundant macro definition.

@CohenArthur
Copy link
Member

@zhanghe9702 I think the title of this PR is wrong - you're not fixing a typo, but you are removing a redundant macro definition. it helps us when reviewing since we can quickly know what a PR is about

@CohenArthur
Copy link
Member

(similarly you should change your commit message to remove the "Fix typo" title)

CohenArthur
CohenArthur approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look good! thank you for noticing it and fixing it :)

@CohenArthur
Copy link
Member

@zhanghe9702 do you want some help with getting this merged?

@zhanghe9702
Copy link
Contributor Author

sorry, i didn't noticed your message , what's your suggestion? i think this just an kind of input error, :), what's the title is better than fixed typo ?

@CohenArthur
Copy link
Member

Something like "Remove redundant macro definition" would be good :) and then in your commit message use that for the title as well, and in the Changelog explain that you're removing the CLASSTYPE_VBASECLASSES macro which was accidentally duplicated three times :)

@zhanghe9702 zhanghe9702 changed the title Fix typo Remove redundant macro definition Apr 22, 2024
@zhanghe9702
Copy link
Contributor Author

i have changed the title, and rebase commit

CohenArthur
CohenArthur approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you :D

@CohenArthur CohenArthur added this pull request to the merge queue Apr 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 23, 2024
@zhanghe9702
Remove redundant macro definition
ea669ec 
gcc/rust/ChangeLog:
	* backend/rust-tree.h: removing the CLASSTYPE_VBASECLASSES macro
	which is duplicated three times.

Signed-off-by: Zhang He <zhanghe9702@163.com>
@CohenArthur CohenArthur added this pull request to the merge queue Apr 23, 2024
Merged via the queue into Rust-GCC:master with commit fa86c37 Apr 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenArthur CohenArthur CohenArthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhanghe9702 @CohenArthur