Removed obsolete objects #2968
Removed obsolete objects #2968
Conversation
| // lookup compiled functions since it may have already been compiled | ||
| fn_expr = resolve_method_address (fntype, receiver, expr.get_locus ()); |
There was a problem hiding this comment.
hmmm, I feel like there used to be/should be a method cache lookup here which does not exist for some reason? maybe it would be better to comment out the two objects and add a FIXME comment?
There was a problem hiding this comment.
oh ok, fixme comment something like this?
// FIXME : method cache lookup
// comment deleted lines
// here
code...
There was a problem hiding this comment.
yes something like this would be good :) but could you investigate that piece of code? was there method lookup at some point here that was removed, or was it just never added?
There was a problem hiding this comment.
I checked with git blame, what I found was that the 2nd object was passed to the below function first, but later function didn't need it, and the above 2 lines were left unchanged
There was a problem hiding this comment.
i asked @philberty about these 2 lines, he told me to go for it
Philip, do you remember what Arthur is talking about?
There was a problem hiding this comment.
that's fine then, we can go ahead and remove them :D thanks for checking!
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
gcc/rust/ChangeLog: * backend/rust-compile-expr.cc (CompileExpr::visit): Lines removed as the objects are unused. Signed-off-by: Kushal Pal <kushalpal109@gmail.com>
Fixes #2967
Created this PR to check if my new setup was working for PRs or not,
I can delete this if you want to save this issue as
good-first-prfor first contributions.