Fix clippy lints #149
Fix clippy lints #149
Conversation
There was a problem hiding this comment.
Thanks @hmvp! This looks good to me. For reference, looks like suspicious_arithmetic_impl is just about using different operations in implementations for things like Add and Subtract than the one being implemented (like using - in an impl for Add), which is why we ignore that one.
Unwrapping inside the config file parsing can lead to some issues that prevent us from falling back to a default configuration file. One instance of that issue was mentioned in #1135. Now all instances of `unwrap()` have been removed and replaced with proper error handling. This will make the config more robust and prevents live reload from silently breaking while alacritty is running. This also fixes a few currently existing clippy issues. Clippy added an additonal lint which complains about `MyStruct { field: field }`. These issues have been fixed, except for some false-positives and issues in external macros which will probably be fixed with future updates (bitflags/bitflags#149)
|
Regarding the implementation of Sub we should consider making clippy a bit more relaxed: rust-lang/rust-clippy#2510 |
|
Update: Clippy has been adjusted rust-lang/rust-clippy#2511, so we no longer need to ignore |
|
Updated the change to remove the now unneeded allow |
Unwrapping inside the config file parsing can lead to some issues that prevent us from falling back to a default configuration file. One instance of that issue was mentioned in alacritty#1135. Now all instances of `unwrap()` have been removed and replaced with proper error handling. This will make the config more robust and prevents live reload from silently breaking while alacritty is running. This also fixes a few currently existing clippy issues. Clippy added an additonal lint which complains about `MyStruct { field: field }`. These issues have been fixed, except for some false-positives and issues in external macros which will probably be fixed with future updates (bitflags/bitflags#149)
|
It looks like clippy may have made both allows unneeded now: stratis-storage/devicemapper-rs#287 |
|
Yes, redundant field names are ignored in macros now: rust-lang/rust-clippy@ed769a3. We should still commit this small cleanup. It's not a breaking change because the shorthand syntax was stabilized in Rust 1.17 and bitflags already requires 1.20. |
Unwrapping inside the config file parsing can lead to some issues that prevent us from falling back to a default configuration file. One instance of that issue was mentioned in alacritty#1135. Now all instances of `unwrap()` have been removed and replaced with proper error handling. This will make the config more robust and prevents live reload from silently breaking while alacritty is running. This also fixes a few currently existing clippy issues. Clippy added an additonal lint which complains about `MyStruct { field: field }`. These issues have been fixed, except for some false-positives and issues in external macros which will probably be fixed with future updates (bitflags/bitflags#149)
The docs are not yet published for the latest clippy but this pull request fixes two clippy warnings you get when using
bitflags!in your codehttps://rust-lang-nursery.github.io/rust-clippy/v0.0.187/index.html#redundant_field_names
https://rust-lang-nursery.github.io/rust-clippy/v0.0.187/index.html#suspicious_arithmetic_impl