Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup basic Windows CI #275

Closed
pietroalbini opened this issue Jul 10, 2018 · 5 comments
Closed

Setup basic Windows CI #275

pietroalbini opened this issue Jul 10, 2018 · 5 comments
Labels
C-enhancement Category: enhancement to an existing feature O-windows OS: Windows

Comments

@pietroalbini
Copy link
Member

@Eh2406 fixed the Windows build in #267, and it would be nice to have Appveyor checking if the code builds to avoid regressions.

cc @alexcrichton @aidanhs #149

@pietroalbini pietroalbini added the C-enhancement Category: enhancement to an existing feature label Jul 10, 2018
@alexcrichton
Copy link
Member

Is crater still heavily docker based? If so that'd narrow the possibilities here a bit and somehow we'd have to build x86_64-pc-windows-gnu libraries on try builds (which we don't currently do, but could in theory do). Otherwise though it may just be getting try builds for Windows working!

@alexcrichton
Copy link
Member

Er wait, sorry, this is just CI, in that case you should be able to enable it at any time (in theory any member of rust-lang-nursery can, AppVeyor permissions are a little wonky though)

@pietroalbini
Copy link
Member Author

I'm not actually a member of rust-lang-nursery though, and I still need to get an appveyor config file up.

@pietroalbini
Copy link
Member Author

@alexcrichton I opened a PR (#278) with a basic appveyor.yml, but I'm not admin of the repo/member of rust-lang-nursery. Can you enable AppVeyor for this repo?

@alexcrichton
Copy link
Member

Ok I've enabled AppVeyor --

Build status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement to an existing feature O-windows OS: Windows
Projects
None yet
Development

No branches or pull requests

2 participants