This repository has been archived by the owner on Aug 16, 2021. It is now read-only.
Add a method to format chained errors. #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yamakaky
reviewed
Jan 9, 2017
| if let Some(backtrace) = e.backtrace() { | ||
| writeln!(stderr, "{:?}", backtrace).expect(errmsg); | ||
| } | ||
| write!(stderr, "{}", $crate::ChainedError::display(e)).expect(errmsg); |
| @@ -444,6 +455,27 @@ pub trait ChainedError: error::Error + Send + 'static { | |||
| where Self: Sized; | |||
| } | |||
|
|
|||
| /// A struct which formats an error for output. | |||
| pub struct Display<'a, T: 'a>(&'a T); | |||
There was a problem hiding this comment.
Would it produce the same output as Display?
There was a problem hiding this comment.
Nevermind, derived it.
| /// | ||
| /// The full cause chain and backtrace, if present, will be printed. | ||
| fn display<'a>(&'a self) -> Display<'a, Self> | ||
| where Self: Sized |
There was a problem hiding this comment.
Are you sure you need this part?
There was a problem hiding this comment.
Yep:
error[E0277]: the trait bound `Self: std::marker::Sized` is not satisfied
--> src/lib.rs:440:5
|
440 | fn display<'a>(&'a self) -> Display<'a, Self> {
| ^ the trait `std::marker::Sized` is not implemented for `Self`
|
= help: consider adding a `where Self: std::marker::Sized` bound
= note: required by `Display`
There was a problem hiding this comment.
Oops, nevermind, I'm dumb.
|
Nice! Could you also update the changelog? |
The main function isn't the only place you might want to print the full error message, for example, to log error messages produced by a handler in a web server.
|
Updated |
|
Cool! |
|
Any idea when this'll land in a release? |
|
Done! |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main function isn't the only place you might want to print the full
error message, for example, to log error messages produced by a handler
in a web server.