Skip to content
This repository has been archived by the owner on Aug 16, 2021. It is now read-only.

added hidden nonexaustive variant #193

Closed
wants to merge 1 commit into from

Conversation

tinaun
Copy link
Contributor

@tinaun tinaun commented Jul 24, 2017

fixes #182

i first tried to add the variant inside error_chain_processed!, but that failed with a weird macro error:

error: attempted to repeat an expression containing no syntax variables matched as repeating at this depth
  --> src\quick_error.rs:98:20
   |
98 |             enum [$( $(#[$emeta])* => $eitem $(( $($etyp),* ))* )*
   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

so i had to drop down to quick_error and impl'd it there. seems to work ok.

@Yamakaky
Copy link
Contributor

Could you update the changelog?

@Yamakaky
Copy link
Contributor

Also, add "Fixes #182" in the commit body.

@tinaun tinaun force-pushed the nonexaustive branch 2 times, most recently from 244b230 to f04a9a7 Compare July 26, 2017 06:23
@faern
Copy link
Contributor

faern commented Aug 29, 2017

Bump. Feedback has been fixed already :)

@faern
Copy link
Contributor

faern commented Aug 29, 2017

@tinaun Rebase it on latest master maybe?

@Yamakaky
Copy link
Contributor

Yes

@tinaun tinaun force-pushed the nonexaustive branch 4 times, most recently from fe2d07d to c04ef44 Compare August 29, 2017 19:57
@Yamakaky
Copy link
Contributor

Yamakaky commented Sep 5, 2017

Sorry for the delay: could you rebase again?

@Yamakaky
Copy link
Contributor

Yamakaky commented Sep 5, 2017

Manually merged, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ErrorKind enum open
3 participants